ryan/Extensions
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

remove retries/sleep

Browse Source
This commit is contained in:
Ryan Peters 2020-09-07 23:41:07 -04:00
parent 2aa9ce3eb7
commit b14d017f43
1 changed files with 61 additions and 113 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

76
BinaryDad.Extensions/RestUtility.cs
View File

@ -3,15 +3,12 @@ using System.Collections.Generic;
using System.IO; using System.IO;
using System.Net; using System.Net;
using System.Net.Http; using System.Net.Http;
using System.Threading;
namespace BinaryDad.Extensions namespace BinaryDad.Extensions
{ {
public class RestUtility public class RestUtility
{ {
public const int DefaultTimeout = 5000; public const int DefaultTimeout = 5000;
public const int DefaultSleepDelay = 3000;
public const int DefaultRetries = 3;
#region Get #region Get
@ -23,10 +20,7 @@ namespace BinaryDad.Extensions
/// <param name="additionalHeaders"></param> /// <param name="additionalHeaders"></param>
/// <param name="timeoutMs">Timeout of the request in milliseconds</param> /// <param name="timeoutMs">Timeout of the request in milliseconds</param>
/// <returns></returns> /// <returns></returns>
public static T Get<T>(string url, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static T Get<T>(string url, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) => Send(url, HttpMethod.Get, typeof(T), null, additionalHeaders, timeoutMs).To<T>();
{
return Send(url, HttpMethod.Get, typeof(T), null, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed).To<T>();
}
/// <summary> /// <summary>
/// Invokes a GET request with optional headers /// Invokes a GET request with optional headers
@ -35,11 +29,9 @@ namespace BinaryDad.Extensions
/// <param name="additionalHeaders"></param> /// <param name="additionalHeaders"></param>
/// <param name="timeoutMs">Timeout of the request in milliseconds</param> /// <param name="timeoutMs">Timeout of the request in milliseconds</param>
/// <returns></returns> /// <returns></returns>
public static string Get(string url, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static string Get(string url, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) =>
{
// response type is always a string if no returnObjectType is used // response type is always a string if no returnObjectType is used
return Send(url, HttpMethod.Get, null, null, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed) as string; Send(url, HttpMethod.Get, null, null, additionalHeaders, timeoutMs) as string;
}
/// <summary> /// <summary>
/// Invokes a GET request with optional headers /// Invokes a GET request with optional headers
@ -51,10 +43,7 @@ namespace BinaryDad.Extensions
/// <param name="sleepDelayMs"></param> /// <param name="sleepDelayMs"></param>
/// <param name="retries"></param> /// <param name="retries"></param>
/// <returns></returns> /// <returns></returns>
public static object Get(string url, Type returnObjectType, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static object Get(string url, Type returnObjectType, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) => Send(url, HttpMethod.Get, returnObjectType, null, additionalHeaders, timeoutMs);
{
return Send(url, HttpMethod.Get, returnObjectType, null, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed);
}
#endregion #endregion
@ -69,10 +58,7 @@ namespace BinaryDad.Extensions
/// <param name="additionalHeaders"></param> /// <param name="additionalHeaders"></param>
/// <param name="timeoutMs">Timeout of the request in milliseconds</param> /// <param name="timeoutMs">Timeout of the request in milliseconds</param>
/// <returns></returns> /// <returns></returns>
public static T Post<T>(string url, object body, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static T Post<T>(string url, object body, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) => Send(url, HttpMethod.Post, typeof(T), body, additionalHeaders, timeoutMs).To<T>();
{
return Send(url, HttpMethod.Post, typeof(T), body, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed).To<T>();
}
/// <summary> /// <summary>
/// Invokes a POST request with optional headers /// Invokes a POST request with optional headers
@ -82,11 +68,9 @@ namespace BinaryDad.Extensions
/// <param name="additionalHeaders"></param> /// <param name="additionalHeaders"></param>
/// <param name="timeoutMs">Timeout of the request in milliseconds</param> /// <param name="timeoutMs">Timeout of the request in milliseconds</param>
/// <returns></returns> /// <returns></returns>
public static string Post(string url, object body, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static string Post(string url, object body, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) =>
{
// response type is always a string if no returnObjectType is used // response type is always a string if no returnObjectType is used
return Send(url, HttpMethod.Post, null, body, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed) as string; Send(url, HttpMethod.Post, null, body, additionalHeaders, timeoutMs) as string;
}
/// <summary> /// <summary>
/// Invokes a POST request with optional headers /// Invokes a POST request with optional headers
@ -99,10 +83,7 @@ namespace BinaryDad.Extensions
/// <param name="sleepDelayMs"></param> /// <param name="sleepDelayMs"></param>
/// <param name="retries"></param> /// <param name="retries"></param>
/// <returns></returns> /// <returns></returns>
public static object Post(string url, Type returnObjectType, object body, Dictionary<string, string> additionalHeaders, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retries = DefaultRetries) public static object Post(string url, Type returnObjectType, object body, Dictionary<string, string> additionalHeaders, int timeoutMs = DefaultTimeout) => Send(url, HttpMethod.Post, returnObjectType, body, additionalHeaders, timeoutMs);
{
return Send(url, HttpMethod.Post, returnObjectType, body, additionalHeaders, timeoutMs, sleepDelayMs, retries);
}
#endregion #endregion
@ -118,10 +99,7 @@ namespace BinaryDad.Extensions
/// <param name="additionalHeaders"></param> /// <param name="additionalHeaders"></param>
/// <param name="timeoutMs">Timeout of the request in milliseconds</param> /// <param name="timeoutMs">Timeout of the request in milliseconds</param>
/// <returns></returns> /// <returns></returns>
public static T Send<T>(string url, HttpMethod method, object body = null, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static T Send<T>(string url, HttpMethod method, object body = null, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) => Send(url, method, typeof(T), body, additionalHeaders, timeoutMs).To<T>();
{
return Send(url, method, typeof(T), body, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed).To<T>();
}
/// <summary> /// <summary>
/// Invokes a request with custom method/verb and optional headers /// Invokes a request with custom method/verb and optional headers
@ -132,10 +110,7 @@ namespace BinaryDad.Extensions
/// <param name="additionalHeaders"></param> /// <param name="additionalHeaders"></param>
/// <param name="timeoutMs">Timeout of the request in milliseconds</param> /// <param name="timeoutMs">Timeout of the request in milliseconds</param>
/// <returns></returns> /// <returns></returns>
public static string Send(string url, HttpMethod method, object body = null, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static string Send(string url, HttpMethod method, object body = null, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout) => Send(url, method, null, body, additionalHeaders, timeoutMs) as string;
{
return Send(url, method, null, body, additionalHeaders, timeoutMs, sleepDelayMs, retriesAllowed) as string;
}
/// <summary> /// <summary>
/// Invokes a request with custom method/verb and optional headers /// Invokes a request with custom method/verb and optional headers
@ -149,13 +124,10 @@ namespace BinaryDad.Extensions
/// <param name="sleepDelayMs"></param> /// <param name="sleepDelayMs"></param>
/// <param name="retriesAllowed"></param> /// <param name="retriesAllowed"></param>
/// <returns></returns> /// <returns></returns>
public static object Send(string url, HttpMethod method, Type returnObjectType, object body = null, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout, int sleepDelayMs = DefaultSleepDelay, int retriesAllowed = DefaultRetries) public static object Send(string url, HttpMethod method, Type returnObjectType, object body = null, Dictionary<string, string> additionalHeaders = null, int timeoutMs = DefaultTimeout)
{ {
var serializedResponse = string.Empty; var serializedResponse = string.Empty;
var success = false;
for (var attempts = 1; attempts <= retriesAllowed && !success; attempts++)
{
var request = WebRequest.CreateHttp(url); var request = WebRequest.CreateHttp(url);
request.Method = method.ToString(); request.Method = method.ToString();
@ -179,8 +151,6 @@ namespace BinaryDad.Extensions
} }
} }
try
{
if (body != null) if (body != null)
{ {
var serializedBody = body.Serialize(); var serializedBody = body.Serialize();
@ -216,29 +186,7 @@ namespace BinaryDad.Extensions
} }
} }
success = true; if (returnObjectType != null)
}
catch
{
// only throw after we have reached our retry limit
if (attempts >= retriesAllowed)
{
throw;
}
}
// if post failed, pause before another attempt
if (!success)
{
Thread.Sleep(sleepDelayMs);
}
else
{
break;
}
}
if (success && returnObjectType != null)
{ {
return serializedResponse.Deserialize(returnObjectType); return serializedResponse.Deserialize(returnObjectType);
} }